From a3bbef5f21882133140d52e3790564b49b2f6a82 Mon Sep 17 00:00:00 2001
From: Norman Feske <norman.feske@genode-labs.com>
Date: Wed, 26 Dec 2018 14:34:21 +0100
Subject: [PATCH] themed_decorator: optionally disable decorations

This patch adds the boolean policy attribute "decoration", which
controls whether window decorations are presented or not. It is enabled
by default. By setting the attribute to "no", matching windows appear
without any border, which is desireable for Sculpt's component graph.

Issue #3096
---
 repos/gems/src/app/themed_decorator/config.h | 11 +++++++++
 repos/gems/src/app/themed_decorator/window.h | 24 +++++++++++++-------
 2 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/repos/gems/src/app/themed_decorator/config.h b/repos/gems/src/app/themed_decorator/config.h
index cf0c8401a..0a4e94014 100644
--- a/repos/gems/src/app/themed_decorator/config.h
+++ b/repos/gems/src/app/themed_decorator/config.h
@@ -39,6 +39,17 @@ class Decorator::Config
 
 		Config(Genode::Xml_node node) : _config(node) {}
 
+		bool show_decoration(Window_title const &title) const
+		{
+			try {
+				Genode::Session_policy policy(title, _config);
+				return policy.attribute_value("decoration", true);
+
+			} catch (Genode::Session_policy::No_policy_defined) { }
+
+			return true;
+		}
+
 		/**
 		 * Return the base color of the window with the specified title
 		 */
diff --git a/repos/gems/src/app/themed_decorator/window.h b/repos/gems/src/app/themed_decorator/window.h
index 32f6fcd0b..957e98026 100644
--- a/repos/gems/src/app/themed_decorator/window.h
+++ b/repos/gems/src/app/themed_decorator/window.h
@@ -239,6 +239,8 @@ class Decorator::Window : public Window_base, public Animator::Item
 
 		Color _color() const { return Color(_r >> 4, _g >> 4, _b >> 4); }
 
+		bool _show_decoration = _config.show_decoration(_title);
+
 		/**
 		 * Nitpicker session that contains the upper and lower window
 		 * decorations.
@@ -327,10 +329,12 @@ class Decorator::Window : public Window_base, public Animator::Item
 
 		void _stack_decoration_views()
 		{
-			_top_view.stack(_content_view.handle());
-			_left_view.stack(_top_view.handle());
-			_right_view.stack(_left_view.handle());
-			_bottom_view.stack(_right_view.handle());
+			if (_show_decoration) {
+				_top_view.stack(_content_view.handle());
+				_left_view.stack(_top_view.handle());
+				_right_view.stack(_left_view.handle());
+				_bottom_view.stack(_right_view.handle());
+			}
 		}
 
 	public:
@@ -340,7 +344,7 @@ class Decorator::Window : public Window_base, public Animator::Item
 		:
 			Window_base(id),
 			Animator::Item(animator),
-			_env(env),_theme(theme), _animator(animator),
+			_env(env), _theme(theme), _animator(animator),
 			_nitpicker(nitpicker), _config(config)
 		{
 			_reallocate_nitpicker_buffers();
@@ -368,7 +372,7 @@ class Decorator::Window : public Window_base, public Animator::Item
 
 		View_handle frontmost_view() const override
 		{
-			return _bottom_view.handle();
+			return _show_decoration ? _bottom_view.handle() : _content_view.handle();
 		}
 
 		Rect _decor_geometry() const
@@ -425,6 +429,8 @@ class Decorator::Window : public Window_base, public Animator::Item
 		{
 			_assign_color(_config.base_color(_title));
 			animate();
+
+			_show_decoration = _config.show_decoration(_title);
 		}
 
 		bool update(Xml_node window_node) override
@@ -467,14 +473,16 @@ class Decorator::Window : public Window_base, public Animator::Item
 				trigger_animation = true;
 			}
 
-			Window_title title = Decorator::string_attribute(window_node, "title",
-			                                                 Window_title("<untitled>"));
+			Window_title const title =
+				window_node.attribute_value("title", Window_title("<untitled>"));
 
 			if (_title != title) {
 				_title = title;
 				trigger_animation = true;
 			}
 
+			_show_decoration = _config.show_decoration(_title);
+
 			/* update color on title change as the title is used as policy selector */
 			Color const base_color = _config.base_color(_title);
 			if (_base_color != base_color) {