remote_rom: improvements and refactoring

Avoid a runtime warning message since our backend does not provide
such constructor functions yet. If a backend requires them, it should
initiate their execution by itself within the backend init functions.

In coherence with the size_guard idea, the remote_rom packets are are
separated into a simple layer packet and a data packet. While basically
only managing common control informations, the layer packet may carry
any payload. The data packet, instead, manages the transmission of the
actual ROM payload and can be attached to the layer packet. This
simplifies the management of the notification packets UPDATE and SIGNAL
since they do not contain fields like 'offset' or 'payload_size'
anymore.

Now, a single thread manages all incoming RPC calls, signals and (thus)
network packets. This will hopefully make further synchronization
enhancements a lot easier.

Further changes:
* Following data packets are identified as such by their offset instead
  of their packet type field. This simplifies the protocol.
* reduced redundancy in the packet building code
* rewrap lines with >79 columns
* fix compiler warnings
* split backend code
* Remove a few unnecessary include and using directives.
* In order to avoid global variables across modules, 'verbose' is a
  member variable now. Later, its value may be set via constructor.
* The nested Rx class is merged with Backend_base. This way, we avoid
  unnecessary maintenance as long as we don't have a clear design for
  ROM multiplexing which may require the management of multiple IP
  addresses etc.
* The HANDLER template argument is removed since client and server
  inherit from Backend_base anyway. The receive method is virtual now.
* The signals packet_avail and ready_to_ack are directly passed to the
  same signal handler now.
* Remove unnecessarily public/protected visibility from some members.
* Remove and add unnecessary and, due to inclusion order, secretly
  missing include directives, respectively.
This commit is contained in:
Edgard Schmidt
2018-10-11 15:53:20 +02:00
committed by Norman Feske
parent 5627797e77
commit c137c595c8
17 changed files with 709 additions and 631 deletions

View File

@@ -1,11 +1,10 @@
# \author Johannes Schlatow
# \date 2016-03-19
SRC_CC += backend/nic_ip/backend.cc
SRC_CC += backend/nic_ip/client.cc backend/nic_ip/server.cc
INC_DIR += $(REP_DIR)/src/lib/remote_rom/backend/nic_ip
LIBS += base net
# include less specificuration
include $(REP_DIR)/lib/mk/remote_rom_backend.inc
CC_CXX_WARN_STRICT =